adjust sendmmsg wrapper to use stack allocated libc types #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bw-solana
previously approved these changes
Dec 20, 2024
steviez
reviewed
Dec 20, 2024
steviez
reviewed
Dec 20, 2024
steviez
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
sendmmsgwrapper on linux allocates vectors to initialize headers and their components (iovec,socketaddr_storage) for each packet. See #3569 for more details.Summary of Changes
This PR stack allocates space in the form of fixed sized arrays for packet headers and their
iovec,socketaddr_storagecomponents. Length is capped atlibc::UIO_MAXIOV(see https://man7.org/linux/man-pages/man2/sendmmsg.2.html).This PR also avoids zeroing all uninitialized
sockaddr_storageslots and just zeroesmem::size_of::<sockaddr_storage>() - mem::size_of::<sockaddr_in>(or its IPv6 counterpart) for each initialized slot.Fixes #3569